Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Starkware support #537

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Remove Starkware support #537

merged 3 commits into from
Feb 14, 2024

Conversation

apaillier-ledger
Copy link
Contributor

@apaillier-ledger apaillier-ledger commented Feb 13, 2024 •
edited
Loading

Description

Remove old Starkware internal "plugin" from the app.
Saves about 8 KB of flash.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@apaillier-ledger apaillier-ledger force-pushed the feat/apa/remove_stark branch 2 times, most recently from aa68168 to 86b50ff Compare February 13, 2024 16:32
tdejoigny-ledger
tdejoigny-ledger approved these changes Feb 14, 2024
View reviewed changes
@apaillier-ledger apaillier-ledger merged commit b2c39a1 into develop Feb 14, 2024
92 of 96 checks passed
@apaillier-ledger apaillier-ledger deleted the feat/apa/remove_stark branch February 14, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdejoigny-ledger tdejoigny-ledger tdejoigny-ledger approved these changes

Assignees

@apaillier-ledger apaillier-ledger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apaillier-ledger @tdejoigny-ledger